Allow more product endpoint names to be valid #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to allow |
|
@whisperity I think the admin of the CodeChecker server should decide it to create such a product or not. |
Product endpoint names can be started with digits or underscores.
csordasmarton
force-pushed
the
fix-valid-product-endpoint-names
branch
from
d45caa1 to
fc4d6b8
Compare
gyorb
approved these changes
May 2, 2018
|
@whisperity yes those product names do not look great but we should not limit the user. The main problem with the current regex is that the product name can not start with a number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product endpoint names can be started with digits or underscores.